@sweetlilmre: Have you had time to make the changes in the software for the new hardware revision?
I think is quite easy, just enable the internal pull ups and invert the button signals, isn't that?
My skills in programing arduino are near to zero.
Printable View
@sweetlilmre: Have you had time to make the changes in the software for the new hardware revision?
I think is quite easy, just enable the internal pull ups and invert the button signals, isn't that?
My skills in programing arduino are near to zero.
Quote:
Originally Posted by spcbm
@spcbm
I just build one prototype with internal pullups. the code change is very easy :
just change
toQuote:
i = key_state ^ KEYS_READ_PINS; // key changed ?
in comms.c source fileQuote:
i = key_state ^ ~KEYS_READ_PINS; // key changed ?
Can the cassette port connector be substituted with a mini-DIN ala C16? I have the mini-DIN to cassette port adapter.
This idea is so awesome so I coudn't help myself and built also one :-)
This version is with no resitors on board (internal pullup are used) :
Attachment 83147Attachment 83148
not so pretty like other builds but it's working perfectly! thanks sweetlilmre for sharing!
@kubino great stuff and good build! I will make the code change with a config switch, if you would like to do so and send a pull request that would be awesome.
Ok i raised pull request. it's first time I played with github so hopefully its OK :D
@kubino: Nice build and thanks for the code info and testing the new hardware revision.
@protek: yes the connector could be a mini din C16 style. I have tested the standard mini din you can buy in the store, and it works but is really difficult to solder and assembly. If you are asking about the possibility to include in the kit, please post in the sales thread or send PM.
@caiusfabricius: this is the sales thread http://www.amibay.com/showthread.php...-kit-Pre-Order
Hi,Quote:
Originally Posted by kubino
The pull request was in order, but I have made a suggestion on changing the code for efficiency. Please check and change and I'll merge when you are done :)
-(e)
yes already done... thanks for suggestion I'm new to audrino c programming so thanks for your patience :D
Hi,Quote:
Originally Posted by kubino
GitHub pull requests are a great way to learn. I had a situation when a pull request I submitted got rejected about 10 times :).
Made the code REALLY clean and modular by the time the owner accepted it (it was a huge patch).
Your pull request still has some issues, I'll comment on GitHub so we don't make the thread a pull-request tracker :)
-(e)